sys/battery: add hysteresis to full level check#483
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add hysteresis for battery charge level check
sys/battery: add hysteresis to full level check
Jul 14, 2026
dlech
reviewed
Jul 14, 2026
Avoids the light blinking red then green a few times before staying solid on green
laurensvalk
force-pushed
the
copilot/feature-battery-hysteresis
branch
from
July 14, 2026 06:58
35be43f to
293c211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Battery voltage fluctuates near the full threshold, causing the charge status light to flicker between red (charging) and green (full).
Changes
LIION_FULL_HYSTERESIS_MVmacro — 100 mV (50 mV/cell) hysteresis band around the full thresholdpbsys_battery_is_full()hysteresis logic — uses astatic bool was_fullto implement a Schmitt-trigger-style check: transitions to full atLIION_FULL_MV(8190 mV), stays full until voltage drops belowLIION_FULL_MV - LIION_FULL_HYSTERESIS_MV(8090 mV)The
staticvariable is zero-initialized by the C standard, so on first call the strict>= LIION_FULL_MVthreshold applies — correctly detecting a battery that is already full at boot.